Omer Frenkel has submitted this change and it was merged. Change subject: core: Extract hardcoded strings to constants ...................................................................... core: Extract hardcoded strings to constants This patch pulls hardcoded strings in PoolConditionFieldAutoCompleter to constants. They are used in follow up frontend patch (sorting columns in Pools main tab in webadmin application). Change-Id: I5ab8dc498dc7d8b0e797a26676c3bf92139a9e65 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt; Bug-Url: https://bugzilla.redhat.com/1104790 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/PoolConditionFieldAutoCompleter.java 1 file changed, 28 insertions(+), 20 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab8dc498dc7d8b0e797a26676c3bf92139a9e65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server