Alona Kaplan has submitted this change and it was merged. Change subject: engine: HostSetupNetworkValidator small cleanup ...................................................................... engine: HostSetupNetworkValidator small cleanup - Changing some variable nams attachmentsById -> existingAttachmentsById networkAttachmentsByNetworkId -> networkAttachmentsFromParamsByNetworkId - Adding new usefull map existingAttachmentsByNetworkId - Remove unneeded check from - 'notRemovingLabeledNetworks' (patch https://gerrit.ovirt.org/#/c/55687 makes it unneeded) - Changing 'validateNotRemovingUsedNetworkByVms()' to check only one network at a time, and not all the networks each iteration. Change-Id: I9a5e64696a77547bcce857bd348e401ab6e10add Bug-Url: https://bugzilla.redhat.com/1322947 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 25 insertions(+), 62 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5e64696a77547bcce857bd348e401ab6e10add Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Edward Haas <edwardh@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>