From Martin Peřina <mperina@redhat.com>:

Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80907 ) Change subject: core: Custom Id is not persisted to the database ...................................................................... core: Custom Id is not persisted to the database When creating a audit log record, there is an option to assign a custom id string to the record, this is used for example when dealing with interfaces where the custom id value gets the interface name in order to handle event flooding correctly. However, the custom id value is used when generating the key for the audit log cache but since it is not persisted to the database, each record in the cache that has a non-empty custom id value will not be cleaned from the cache since the key for searching this record will have always an empty custom id value. This behavior may lead to cache flooding and memory leak. Change-Id: I4867253abd8ef35dbab6ecd28cc2aa9a8bae15aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1483889 Signed-off-by: emesika <emesika@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_02_0540_add_audit_log_custom_id.sql 7 files changed, 26 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4867253abd8ef35dbab6ecd28cc2aa9a8bae15aa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>