Roy Golan has submitted this change and it was merged. Change subject: core: hosted-engine: import the domain only when DC is UP ...................................................................... core: hosted-engine: import the domain only when DC is UP Most of the setups will be concluded by an engine restart (configurable). At that stage the import may have already kicked in, and this race causes - 1) a reboot during the import - may lead to failed rollback, so we're left with junk in DB 2) An attemt to Attach before we have an UP host. This leads to a rollback which may lead to closure 1. As long as we don't attempt to add a data domain during HE setup, this approch will keep us safe and will import the domain while there isn't a restart planned. Change-Id: I2710be830cdb234fbb38456234219389e9299833 Bug-Url: https://bugzilla.redhat.com/1293928 Bug-Url: https://bugzilla.redhat.com/1290518 Signed-off-by: Roy Golan <rgolan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java 2 files changed, 37 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/51126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2710be830cdb234fbb38456234219389e9299833 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>