From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. (
https://gerrit.ovirt.org/79523 )
Change subject: core: Relocate filterConnectionsByStorageType
......................................................................
core: Relocate filterConnectionsByStorageType
Move filterConnectionsByStorageType to the only place it's used,
AbstractDiskVmCommand.
To align with the production code, StorageHelperBaseTest (which only
contains tests for this method) was removed, and a new
AbstractDiskVmCommandTest was introduced.
Change-Id: Iff01f5bcfe626c199b09dfff6a749aac292f5c2b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java
R
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommandTest.java
3 files changed, 11 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/79523
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff01f5bcfe626c199b09dfff6a749aac292f5c2b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>