Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: move mail specific validations into smtp transport ...................................................................... tools: notifier: move mail specific validations into smtp transport the static usage will be altered once we reorder transport creation. Change-Id: I5c956198a2bb41deff7259607feb83dfe1a7ad53 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/JavaMailSender.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java 4 files changed, 114 insertions(+), 113 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c956198a2bb41deff7259607feb83dfe1a7ad53 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server