Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Replace ANTLRv4 with JavaCC in OsInfo validation ...................................................................... core: Replace ANTLRv4 with JavaCC in OsInfo validation A replacement for the ANTLRv4-based validator for the OsInfo properties file. It uses JavaCC instead, this has the following advantages: - Generates code that does not depend on any external dependency - The build dependency is already properly packaged in most distros On the other hand, the syntax for the grammar file is not as clean as the ANTLR version. Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1170258 Signed-off-by: Vitor de Lima <vdelima@redhat.com> --- M backend/manager/dependencies/pom.xml D backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml D backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java A backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M pom.xml 9 files changed, 238 insertions(+), 283 deletions(-) Approvals: Vitor de Lima: Verified Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68f11f4616ab488d4caf7f8073b4b423ab0c46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server