Shahar Havivi has submitted this change and it was merged. Change subject: core: ticket utils: use SecureRandom ...................................................................... core: ticket utils: use SecureRandom I had a glance at java implementation of basic Random, and it is bad for us to generate the salt. So I suggest to use SecureRandom instead. Change-Id: Idaaf8b9cc4c4afeb62d5ad5ba86fcb4878de09a8 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaaf8b9cc4c4afeb62d5ad5ba86fcb4878de09a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>