Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Introduce GinUiBinder ...................................................................... frontend: Introduce GinUiBinder Added support for the GinUiBinder feature of GWTP 1.3. GinUiBinder replaces the standard GWT UiBinder with GTWP's implementation adding support for injecting GIN dependencies into views created by UiBinder. This can be greately beneficial in many cases where we use @UiField(provided=true) just to pass dependencies to child views. In order to create GIN-enabled view, just use @Inject annotated constructor where you inject required dependencies (you can also inject editor Driver and IdHandler instead of GWT.create-ing them) and add method returning type of your view to the apropriate GinUiBinderWidgets ginjector extension. The ginjector extensions for respective modules are: * gwt-common: CommonGinUiBinderWidgets * webadmin: WebAdminGinUiBinderWidgets * userportal-gwtp: UserPortalGinUiBinderWidgets Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/CommonGinUiBinderWidgets.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientGinjectorExtension.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalGinUiBinderWidgets.java M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 13 files changed, 127 insertions(+), 79 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ac93ae3c8a80f5b49a0780ed8c9a674a109779 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server