Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Validate disk model properties before flushing ...................................................................... webadmin: Validate disk model properties before flushing Since commit 4dc19d308aa6f7944924c92908016c1b67f62544 the disk properties are flushed before saving, this overrides the validation phase and in case of setting of a primitive value to null, the unboxing throws an NPE. Added a call to validation before flushing to solve this problem Change-Id: Ifa982d1f2fff9c0b90a9a23f9480ce99b20f9e25 Bug-Url: https://bugzilla.redhat.com/1215974 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified -- To view, visit https://gerrit.ovirt.org/40741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa982d1f2fff9c0b90a9a23f9480ce99b20f9e25 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org