Omer Frenkel has submitted this change and it was merged. Change subject: core: organize can-do methods ...................................................................... core: organize can-do methods AddVmCommand#canAddVm: 1. Return false with an error as soon as a problem is detected instead of using the 'returnValue' field to store the result 2. Inline the 'exists' variable AddVmFromScratchCommand#canDoAction: 1. Return false with an error as soon as a problem is detected instead of using the 'result' field to store the result 2. Remove redundant addition of action messages VdcBllMessages.VAR__ACTION__ADD and VdcBllMessages.VAR__TYPE__VM as they are already added by AddVmCommand Change-Id: I4589fa4681913e41b1be595131686932d92ca062 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 2 files changed, 15 insertions(+), 26 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/15959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4589fa4681913e41b1be595131686932d92ca062 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server