Tal Nisan has submitted this change and it was merged. Change subject: webadmin: v2v- avoid closing wizard if vm's validation failed ...................................................................... webadmin: v2v- avoid closing wizard if vm's validation failed In case that one or more VMs failed in validation phase (due to non unique name in data center or any other validation failure), a warning dialog is displayed with relevant message and when clicking "ok", the v2v wizard is displayed back in its last state and not closed as it was before. Notes: 1. The VM name uniquness is per Data Center and therefore the relevant message was rephrased to inform that the VM already exists in Data Center and not in the whole system. 2. in case that at least one of the VMs failed in validation phase, all valid VMs import will also stopped from proceeding. In such a case, a message is displayed and the user can go back to v2v wizard to fix it. The import will start for all VMs only in case all are valid. Change-Id: I82bf607127322caf4ef246c25cd9b1848192ce18 Bug-Url: https://bugzilla.redhat.com/1364171 Signed-off-by: Sharon Gratch <sgratch@redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromOvaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 20 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82bf607127322caf4ef246c25cd9b1848192ce18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>