Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing harmfull code from persitance of task to DB ...................................................................... engine: Removing harmfull code from persitance of task to DB The following code which is removed is useless, because of json serializer will not serialize parentParameters because of it is transient, but during setting them to null we can create a race which will destroy a correct value, in case if command triggered couple parallel tasks Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Signed-off-by: Michael Kublin <mkublin@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>