Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: optionally restore permissions
......................................................................
packaging: engine-backup: optionally restore permissions
If backing up with the custom dump format (which is the default), do
backup with owner and privileges, thus partially reverting I78fa18fe0d.
During restore, the user must pass one of '--restore-permissions' and
'--no-restore-permissions'.
With plain dump format, permissions are not backed up nor restored.
Also make engine-setup backup extra permissions on db objects and
restore them during rollback.
Bug-Url:
https://bugzilla.redhat.com/1220791
Change-Id: Ib594d68c2f3539abf30ebb3f8f525cc366bfec26
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
M packaging/setup/ovirt_engine_setup/engine_common/database.py
2 files changed, 53 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit
https://gerrit.ovirt.org/49584
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib594d68c2f3539abf30ebb3f8f525cc366bfec26
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>