Change in ovirt-engine[master]: engine: Add/UpdateVmInterfaceCommand fix compensation

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add/UpdateVmInterfaceCommand fix compensation ...................................................................... engine: Add/UpdateVmInterfaceCommand fix compensation 'VmBase.ssoMethod' field caused the bug. The enum 'SsoMethod' overrides 'toString()' method. Since 'JsonObjectDeserializerFactory' uses 'EnumResolver.constructUnsafeUsingToString' to create a map of enum keys to enum values, the key of the map is the value of the 'toString()' -> the lower case name of the enum. On the other hand, the serializer uses the 'name()' method as the key of the serialized enum. Since in 'SsoMethod' the 'name()' and the 'toString()' are not the same, the deserialier cannot find the serialized enum. Added '@JsonCreator' and '@JsonValue' to make sure the key in both serialization and deserialization will be the same. Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Bug-Url: https://bugzilla.redhat.com/1338601 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
alkaplan@redhat.com