Allon Mureinik has submitted this change and it was merged. Change subject: core: FenceValidatorTest config mocking ...................................................................... core: FenceValidatorTest config mocking Replaced the manual mocking with the project's standard MockConfigRule. This approach has two benefits: - From a maintenance standpoint, the standartization and the clearer syntax make it easier to understand - From a correctness standpoint, the original manual mocking neglected to clear up the mock IConfigUtilsInterface instance placed in Config's static variable, so it could potentially leak out of this test and affect other tests in an unexpected manner. Change-Id: I6d271e49ed165c2d05968c39801872b7b02f7ded Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d271e49ed165c2d05968c39801872b7b02f7ded Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>