Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: messages locale unit test ...................................................................... userportal,webadmin: messages locale unit test - Added unit tests for all the locale messages which check the following: - The number of parameters on the interface match the parameters on each locales translation. This takes @Optional into account, so if there are 3 parameters and one optional, then 2 or 3 parameters are acceptable. - There are no out of bounds indexes in the translation, for instance if there are 2 parameters, there is no {2} or higher in the translated messages (the index starts at 0). - Checks if there is a default translation for missing translations - If any of these conditions occur the unit test will fail and report all errors to the user. Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Signed-off-by: Alexander Wels <awels(a)redhat.com&gt; --- M frontend/webadmin/modules/gwt-common/pom.xml A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/CommonApplicationMessagesTest.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/GwtMessagesValidator.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml A frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ApplicationMessagesTest.java M frontend/webadmin/modules/webadmin/pom.xml A frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ApplicationMessagesTest.java M pom.xml 9 files changed, 294 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server