Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: all disks were by default bootable for instance images ...................................................................... userportal,webadmin: all disks were by default bootable for instance images The problem was that the new disk dialog opened from the new VM dialog was always "bootable: true". Fixed by 2 changes: - overridden the AbstractDiskModel.updateBootableDiskAvailable() in instance images models. The difference is that in the default implementation it takes the disks from server while in case of instance images from the dialg (not yet saved changes) - if created the disk image from the VM dialog (e.g. instance image) it is set "active" since it has to be considered to be active (e.g. no other disks has tbe bootable) Change-Id: Ifb699b2c1d8c2124b69d8032eefd8ba8e185844f Bug-Url: https://bugzilla.redhat.com/1213257 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb699b2c1d8c2124b69d8032eefd8ba8e185844f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server