From Allon Mureinik <amureini@redhat.com>:

Allon Mureinik has submitted this change and it was merged. Change subject: core: ConfigureConsoleOptionsQueryTest mocking ...................................................................... core: ConfigureConsoleOptionsQueryTest mocking VdcQueryReturnValue is a POJO with no interesting logic defined in the common module. As such, there's very little benefit in mocking it instead of just returning a new instance in the test. Besides cleaning up the code, this patch mainly lays some ground work towards making VdcQueryReturnValue final. Change-Id: I920d6b94f3714e0d72773a841895b90f87c6fe4b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I920d6b94f3714e0d72773a841895b90f87c6fe4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>