Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust DetachNetworkFromVdsInterfaceCommand to accept any vlan name ...................................................................... engine: Adjust DetachNetworkFromVdsInterfaceCommand to accept any vlan name Changes done in the command- 1. The command uses iface.getBaseInterface() and iface.getVlanId() instead of determining this values from the vlan device name (since its format is no longer- baseIface.vlanId). 2. The command uses the new methods indroduced in NetworkUtils instead of the old ones (that should be removed in a following patch). Change-Id: I2c90bbbc1b3d6bd8df87c83301956556d1c6eafd Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c90bbbc1b3d6bd8df87c83301956556d1c6eafd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server