Tomas Jelinek has submitted this change and it was merged. Change subject: engine: It is not possible to take prestared VM from pool (#844917) ...................................................................... engine: It is not possible to take prestared VM from pool (#844917) https://bugzilla.redhat.com/844917 The problem was in AttachUserToVmFromPoolAndRunCommand which set the "returnValue" and "succeeded" only after the VM has been started - so ignoring the pre-stared VMs. It is safe to set the succeeded to true in that else block because if any error occures, the method returns earlier. Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39 Signed-off-by: Tomas Jelinek <tjelinek@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com>