Tal Nisan has submitted this change and it was merged.
Change subject: core: Return empty list if no VM numa nodes are present
......................................................................
core: Return empty list if no VM numa nodes are present
Let AddVmNumaNodesCommand and VM always return an empty list instead of
null if no numa configuration is present to avoid confusing null checks.
Bug-Url:
https://bugzilla.redhat.com/1279178
Bug-Url:
https://bugzilla.redhat.com/1177259
Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
3 files changed, 12 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roman Mohr: Verified
Roy Golan: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/49056
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>