Ofer Schreiber has submitted this change and it was merged. Change subject: compat: remove unsafe and unneeded Encoding class ...................................................................... compat: remove unsafe and unneeded Encoding class Left over from legacy code. Base64 usage is thread unsafe. String usage is not required. Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M backend/manager/modules/compat/pom.xml D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Encoding.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/EncodingTest.java M backend/manager/modules/engineencryptutils/pom.xml M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 10 files changed, 24 insertions(+), 112 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>