Oved Ourfali has submitted this change and it was merged. Change subject: core: improving error messages in adbroker ...................................................................... core: improving error messages in adbroker This patch improves the error messages in the adbroker project, in case of authentication errors: 1. Printing the message and not the full callstack, for readability. The full call stack is printed only in debug log mode. 2. In case of "client not found in kerberos database" error, we return a proper error to the user (instead of the "invalid credentials" error we returned so far). Change-Id: I345205621e55e99d8cbce5720f6ed961cfa07c71 Signed-off-by: Oved Ourfali <oourfali@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosReturnCodeParser.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 20 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/5657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I345205621e55e99d8cbce5720f6ed961cfa07c71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>