Barak Azulay has submitted this change and it was merged. Change subject: Revert "Remove contra productive _string_check" ...................................................................... Revert "Remove contra productive _string_check" This reverts commit b06a6c4c8e61013b7461c6fc946c1530ae47584e. The previous commit breaks the guest agent badly because the string type is required to be unicode, this code previously was converting it most of the times to unicode, however in some cases it won't do so and causes the data to be an ascii string or even replaces valid characters even though it should not. The attempt for fixing this issue will be addressed by a new patch. Change-Id: I47176ac60e069e7d557312d7047d9bc4b15ac768 Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47176ac60e069e7d557312d7047d9bc4b15ac768 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr@redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr@redhat.com>