Allon Mureinik has submitted this change and it was merged. Change subject: core: Cleanup engine-config.properties ...................................................................... core: Cleanup engine-config.properties engine-config.properties should represent a subset of ConfigValues users are able to control easily. Several careless patches have left obsolete references in it that do not represent valid config values any more and just confuse users. This patch removes these obsolete entries and introduces a unit test which evaluates packaging/etc/engine-config/engine-config.properties against the ConfigValues enum to ensure such mistakes don't happen again. Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/tools/pom.xml A backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigPropertiesTest.java M packaging/etc/engine-config/engine-config.properties 3 files changed, 54 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f30d45e80bb3c8918a16148523b1e405185abc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>