Tal Nisan has submitted this change and it was merged. Change subject: engine: Improve iSCSI Bond CDA validation ...................................................................... engine: Improve iSCSI Bond CDA validation Add following CDA validations due to adding iSCSI Multipathing support through the REST API: 1. Validate that datacenter version is at least 3.4. 2. Validate that added logical networks belong to the same datacenter as the specified iSCSI Bond and that none of them is "required" network. 3. Validate that added storage targets are indeed iSCSI targets, they are "connectable" and they belong to the storage domain from the same datacenter as the specified iSCSI Bond. Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Bug-Url: https://bugzilla.redhat.com/1093393 Signed-off-by: Sergey Gotliv <sgotliv@redhat.com> Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IscsiBondValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/IscsiBondValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 427 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: A Burden <aburden@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server