Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix FB on AddExistingFileStorageDomain ...................................................................... core: Fix FB on AddExistingFileStorageDomain This patch reverts 5ccea20c205457f70cbd480f80455f600b386836 and offers a proper fix for the (bogus) NP_NULL_PARAM_DEREF error in AddExistingFileStorageDomainCommand. The domainFromIrs variable can NEVER be null, hence it's meaningless to protect against it. Change-Id: Id8c5a11ef872cac6aeebfa18bf28757fb4a8b26c Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 11 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8c5a11ef872cac6aeebfa18bf28757fb4a8b26c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server