Daniel Erez has submitted this change and it was merged. Change subject: webadmin: NewEditStorageModelBehavior refactor ...................................................................... webadmin: NewEditStorageModelBehavior refactor - Refactor items availability logic in NewEditStorageModelBehavior (I.e. extract the numerous conditions into boolean flags). - Remove the deprecated export Iscsi/FCP models from the items list (simplifies the availability conditions). Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 19 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>