Itamar Heim has submitted this change and it was merged. Change subject: tools: notifier: Notification properties changes. ...................................................................... tools: notifier: Notification properties changes. Before this change validation was done both in NotificationService.initConfigurationProperties and in NotificationProperties itself. all moved to NotificationProperties. The properties themself are not read from the notification service to be instance variables inside the notifier but are read each time they are needed. Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e Signed-off-by: Mooli Tayer <mtayer(a)redhat.com&gt; --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java 2 files changed, 92 insertions(+), 118 deletions(-) Approvals: Eli Mesika: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/24694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server