Tal Nisan has submitted this change and it was merged. Change subject: core: compare dedicated hosts against template on add vm ...................................................................... core: compare dedicated hosts against template on add vm On add-VM we used to require permission on action-group ActionGroup.EDIT_ADMIN_VM_PROPERTIES if the VM we get in the parameters contains non-empty list of dedicated-hosts. By default, this list contains the dedicated hosts that are set in the template. So as a result we required users to have that permission in order to create a VM from any temaplte that is set with dedicated hosts, even when they did not change the template's setting. This patch fixes it by changeing the check in add-VM so it will compare the list in the given VM with the list that is set in the template so ActionGroup.EDIT_ADMIN_VM_PROPERTIES will be required only if the list of the dedicated hosts was changed by the user. Change-Id: Iab1a8536e1da5c529d735542d21b004a15c5fbf4 Bug-Url: https://bugzilla.redhat.com/1284472 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab1a8536e1da5c529d735542d21b004a15c5fbf4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>