Laszlo Hornyak has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup. ...................................................................... core: ImagesHandler cleanup. FindBugs issue - ImagesHandler.java:685, MS_SHOULD_BE_FINAL, Priority: Low org.ovirt.engine.core.bll.ImagesHandler.log isn't final but should be A mutable static field could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a Signed-off-by: Sharad Mishra <snmishra@linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra@linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>