Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79534 ) Change subject: core: StorageServerCommandBase#findConnectionWithSameDetails ...................................................................... core: StorageServerCommandBase#findConnectionWithSameDetails StorageServerCommandBase#findConnectionWithSameDetails is a useless delegator only used for unit tests. With the ability to inject a mock to the ISCSIStorageHelepr it delegates to, this method becomes useless, and can easily be removed. Change-Id: I25cc9e5c35f51ac2ecbaf41b398f6efd89fd03a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java 3 files changed, 11 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25cc9e5c35f51ac2ecbaf41b398f6efd89fd03a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;