Moti Asayag has submitted this change and it was merged. Change subject: core: reduce code duplication in ovf readers ...................................................................... core: reduce code duplication in ovf readers Introduce a method for reading a property from the OVF and invoking a given consumer that typically updates the entity accordingly. Change-Id: I3b7b61fbed16f863e46d2e1994aebdfb9474004b Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 232 insertions(+), 446 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/78395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b7b61fbed16f863e46d2e1994aebdfb9474004b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com&gt;