Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix name uniqueness chack in ImportVmModel ...................................................................... frontend: Fix name uniqueness chack in ImportVmModel Now when checking the name uniqueness of imported VM, we check for conflict only VMs in target data center. To facilitate this the data center loading part from ImportVmFromExportDomainModel#doInit() and ImportVmFromExternalProviderModel#doInit() had to be extracted into special helpers withDataCenterLoaded() that are used to wrap the setItems() method doing the name uniqueness analysis - since it requires access to storagePool.id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912263 Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 4 files changed, 102 insertions(+), 79 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c8b17bee0d676bc09c758e98439e5d672eb885 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>