Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Remove constants duplication ...................................................................... packaging: setup: Remove constants duplication Change-Id: I56d04c7a5dafdbc79bf8312d3aaed69b70fd230c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com&gt; --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 10 files changed, 29 insertions(+), 246 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Objections: Yedidyah Bar David: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/65129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d04c7a5dafdbc79bf8312d3aaed69b70fd230c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com&gt; Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;