Asaf Shakarchi has submitted this change and it was merged. Change subject: api: Current:currents needs to be static to avoid deadly embrace. ...................................................................... api: Current:currents needs to be static to avoid deadly embrace. Discovered by findbugs: org.ovirt.engine.api.common.invocation.Current$1 needs to be _static_ to avoid a deadly embrace with org.ovirt.engine.api.common.invocation.Current.currentsFirst. By definition: ThreadLocal instances are typically private static fields in classes that wish to associate state with a thread. Change-Id: I86516044e758aa526f7bab570d41567b35176029 Signed-off-by: Asaf Shakarchi <asaf@redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86516044e758aa526f7bab570d41567b35176029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>