[JIRA] (OVIRT-1138) lago check-merged jobs mass trigger all PRs

lago check-merged jobs mass trigger all PRs ------------------------------------------- Key: OVIRT-1138 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1138 Project: oVirt - virtualization made easy Issue Type: Improvement Reporter: Nadav Goldin Assignee: infra This might be related to one of the recent Jenkins upgrades(core or git/github). The offending job: http://jenkins.ovirt.org/job/lago_master_check-merged-pipeline/295/ which triggered: http://jenkins.ovirt.org/job/lago_master_check-merged-pipeline/295/console which triggered: http://jenkins.ovirt.org/job/lago_master_check-merged-fc25-x86_64/63/ http://jenkins.ovirt.org/job/lago_master_check-merged-fc24-x86_64/198/ http://jenkins.ovirt.org/job/lago_master_check-merged-el7-x86_64/352/ Each one of the last jobs, was triggered without a 'sha1' parameter, and therefore, triggered the job for every branch: {code} 10:50:28 Seen branch in repository origin/jenkins_download_progress 10:50:28 Seen branch in repository origin/lago-tutorial 10:50:28 Seen branch in repository origin/master 10:50:28 Seen branch in repository origin/pull/418/head 10:50:28 Seen branch in repository origin/removing_lago-ovirt 10:50:28 Seen branch in repository origin/revert_repoman_conf 10:50:28 Seen branch in repository origin/update_install_procedure 10:50:28 Seen 14 remote branches 10:50:28 Multiple candidate revisions 10:50:28 Scheduling another build to catch up with lago_master_check-merged-fc25-x86_64 {code} This went on recursively, flooding Jenkins. My current suspect is this message in the -pipeline job: {code} Using the ‘stage’ step without a block argument is deprecated {code} Which only appeared in this job(and after the Jenkins upgrade). This change is documented here: https://jenkins.io/doc/pipeline/steps/pipeline-stage-step/#pipeline-stage... So to conclude the task for this ticket: 1. Fix the groovy script(if that is really the cause). 2. Alter the job so if the 'sha1' is empty, it will fail early.