Re: About merging patches without tests
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Pt3RJE6ISgLjv0vd0oS42hnm3rohO2BCD
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Fri 16 May 2014 09:33:44 AM CEST, Sandro Bonazzola wrote:
Il 15/05/2014 18:46, David Caro ha scritto:
> Hi!
>
> From time to time we have some patches that are merged to master branc=
hes
> without having been tested mostly because the developer merges
before =
having any
> response from the jenkins system.
>
> Merging one of those patches makes any following test run on that bran=
ch to
> fail, and creating a lot of noise and trouble around all patches
and j=
obs.
>
> So I wanted to stat a little discussion to bring up ideas on how to pr=
event
> that. Some random thoughts:
>
> * -1 the patch at jenkins job start, and reset to 0 on success or infr=
a
failure,
> and keep -1 if jenkins failure
> * Only send a message to the patch with 'jenkins jobs started'
I think that something like "jenkins jobs started, please don't merge u=
ntil they finish" should be enough.
> * Setup zuul as gateway, and make it block the patches if they do not =
pass
the tests
>
>
>
> Cheers!
>
>
>
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
Usually the flow is reabase -> submit, that is done pretty easily from=20
the ui, and it does not give too much time to check any comments (the=20
rebase and submit buttons are on the top, and the comments show at the=20
end).
So doing that will not help on that case, as the developer would not=20
see the comment before submitting. I think we should block, at least=20
for a couple minutes, so he has to read the comments to be able to=20
submit.
We had that before also, adding a comment when the jobs start, but we=20
removed it by developers request iirc
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--Pt3RJE6ISgLjv0vd0oS42hnm3rohO2BCD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJTdc4sAAoJEEBxx+HSYmnDEwoH/jlqzjSjQPHZcsX5vJZlwIuh
B+yAIgpWqmsrdWYt7IMQXi4+FFc/4xpsnpqCtyM28gy4f96OFTJ/lXdCBkcyTDeS
+55wEB0fuOFUQVFwWbvojKoNWZvWTyeuu9bQDBvk4tJO9RMANZo/pKEqwKWyBS91
dCsuEWoYWfNwES0nFRkTUckIm+4HdGyafgX/nkW3Qih0SirP5xXLKb/CRaZklr82
oyd8vj4CfEhdfuj01OH3Xob/nDcwUKJxTQ2mM4itXdZQCXqiKnGjWxOOLybjtBYW
q9LGQvQNDhFHxQa17+8eCxGKa5UpGJ5hIz4SxKbEvsD8x66COT0H2Y3gXJ+tdjY=
=ykCW
-----END PGP SIGNATURE-----
--Pt3RJE6ISgLjv0vd0oS42hnm3rohO2BCD--
Attachments:
- attachment.bin (multipart/signed — 2.7 KB)