Re: Maintainer rights on vdsm - ovirt-3.5-gluster
On Wed, Apr 29, 2015 at 12:04:52PM +0200, David Caro wrote:
On 04/29, Balamurugan Arumugam wrote:
>
>
> ----- Original Message -----
> > From: "David Caro" <dcaro(a)redhat.com>
> > To: "Sahina Bose" <sabose(a)redhat.com>
> > Cc: "Dan Kenigsberg" <danken(a)redhat.com>, infra(a)ovirt.org,
"Balamurugan Arumugam" <barumuga(a)redhat.com>,
> > devel(a)ovirt.org
> > Sent: Wednesday, April 29, 2015 1:38:03 PM
> > Subject: Re: Maintainer rights on vdsm - ovirt-3.5-gluster
> >
> > You want also push rights? It's not the same submit, push, create
reference,
> > verify, code review.
> >
> > All those are different rights. I've added the submit, code-review and
verify
> > rights. Let me know if you want also the rest.
> >
> >
> > Also note that pushing and submitting is not the same, pushing will skip
> > gerrit
> > and any gerrit checks, so it's usually something to avoid. While
submitting
> > is
> > done through gerrit, what allows gerrit to check validity of the code to be
> > merged (gerrit hooks, updating bugzillas, jenkins jobs, signed-by flabs).
> >
>
> The idea behind push right is that we would do periodical rebase of
ovirt-3.5-gluster branch with ovirt-3.5 branch. Is this recommended way to do that?
>
Which kind of rebase? Does it require using --force?
Yes. The expected use case is as such:
- Bala merges patches onto his ovirt-3.5-gluster branch via gerrit.
- Important patches are merged onto ovirt-3.5 by Yaniv.
- Bala wants to have them in ovirt-3.5-gluster
- Bala rebases ovirt-3.5-gluster on top of ovirt-3.5 on his host, and
pushes the new has as the tip new of ovirt-3.5-gluster.
Pleaes let him do that!
Dan.