11:17 a.m.
This is a multi-part message in MIME format...
------------=_1508055425-13372-146
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
[
https://ovirt-jira.atlassian.net/browse/OVIRT-1689?page=com.atlassian.jir...
]
eyal edri commented on OVIRT-1689:
----------------------------------
Can you improve the title and description? its not clear which errors messages you're
referring to.
Improve error messages
-----------------------
Key: OVIRT-1689
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1689
Project: oVirt - virtualization made easy
Issue Type: Improvement
Components: oVirt CI
Reporter: Daniel Belenky
Assignee: infra
* All references to things like 'xdg-home' need to be replaced with
specifications of actual paths, as users are not expected to know what XDG is.
* Accurate indication of what is missing from which file and what can be done to fix it
need to be given in all error messages.
* When variable/key names are given in error messages, they need to be quoted for
clarity.
* Edge cases like for example an existing but empty secrets file and a missing
'secrets_data' key need to be handled better, with clear error messages
* Error message when a requested env var is missing needs to be improved to tell the
user what to do. Current message can be very confusing when trying to use
'mock_runner.sh' for the 'jenkins' repo for example.
--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100065)
------------=_1508055425-13372-146
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
<html><body>
<pre>[
https://ovirt-jira.atlassian.net/browse/OVIRT-1689?page=com.atlassian.jir...
]</pre>
<h3>eyal edri commented on OVIRT-1689:</h3>
<p>Can you improve the title and description? its not clear which errors messages
you're referring to.</p>
<blockquote><h3>Improve error messages</h3>
<pre> Key: OVIRT-1689
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1689
Project: oVirt - virtualization made easy
Issue Type: Improvement
Components: oVirt CI
Reporter: Daniel Belenky
Assignee: infra</pre>
<ul><li><p>All references to things like ‘xdg-home’
need to be replaced with specifications of actual paths, as users are not expected to know
what XDG is.</p></li>
<li><p>Accurate indication of what is missing from which file and what can be
done to fix it need to be given in all error messages.</p></li>
<li><p>When variable/key names are given in error messages, they need to be
quoted for clarity.</p></li>
<li><p>Edge cases like for example an existing but empty secrets file and a
missing ‘secrets_data’ key need to be handled better, with clear error
messages</p></li>
<li><p>Error message when a requested env var is missing needs to be improved
to tell the user what to do. Current message can be very confusing when trying to use
‘mock_runner.sh’ for the ‘jenkins’ repo for
example.</p></li></ul></blockquote>
<p>— This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100065)</p>
<img
src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpS...
alt="" width="1" height="1" border="0"
style="height:1px !important;width:1px !important;border-width:0
!important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0
!important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0
!important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>
------------=_1508055425-13372-146--