EL7 build issues for vdsm-jsonrpc-java

Hi, could you please take a look at EL7 build issue for patch [1]? Fedora build is OK, so I'm not sure what we missed that EL7 build is still failing ... Thanks Martin [1] https://gerrit.ovirt.org/64481

Martin, I restarted the build in the morning to see why it is failing. Jsonrpc building looks good but later it fails with: *09:37:52* java.lang.ArrayIndexOutOfBoundsException: 24064*09:37:52* at org.objectweb.asm.ClassReader.readClass(Unknown Source)*09:37:52* at org.objectweb.asm.ClassReader.accept(Unknown Source)*09:37:52* at org.objectweb.asm.ClassReader.accept(Unknown Source)*09:37:52* at org.fedoraproject.maven.installer.impl.DefaultInstaller.usesNativeCode(DefaultInstaller.java:545)*09:37:52* at org.fedoraproject.maven.installer.impl.DefaultInstaller.installArtifact(DefaultInstaller.java:574)*09:37:52* at org.fedoraproject.maven.installer.impl.DefaultInstaller.install(DefaultInstaller.java:758)*09:37:52* at org.fedoraproject.maven.tools.installer.InstallerCli.run(InstallerCli.java:174)*09:37:52* at org.fedoraproject.maven.tools.installer.InstallerCli.main(InstallerCli.java:187)*09:37:52* error: Bad exit status from /var/tmp/rpm-tmp.kU3zTr (%install) this issue started to occur with Ravi's patch. I think that is maybe related somehow to java8 changes. Maybe there is a bug in mavenlocal. We need to investigate. Thanks, Piotr On Fri, Sep 30, 2016 at 2:40 PM, Martin Perina <mperina@redhat.com> wrote:

make[1]: Leaving directory `/home/jenkins/workspace/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/vdsm-jsonrpc-java/rpmbuild/BUILD/vdsm-jsonrpc-java-1.3.1_master' + xmvn-install -R .xmvn-reactor -n vdsm-jsonrpc-java -d /home/jenkins/workspace/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/vdsm-jsonrpc-java/rpmbuild/BUILDROOT/vdsm-jsonrpc-java-1.3.1-master.el7.centos.x86_64 [INFO] =============================================== [INFO] SOURCE ARTIFACT: [INFO] groupId: org.ovirt.vdsm-jsonrpc-java [INFO] artifactId: root [INFO] extension: pom [INFO] classifier: [INFO] version: 1.3.1-SNAPSHOT [INFO] stereotype: pom [INFO] namespace: [INFO] file: /home/jenkins/workspace/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/vdsm-jsonrpc-java/rpmbuild/BUILD/vdsm-jsonrpc-java-1.3.1_master/pom.xml [INFO] ----------------------------------------------- [INFO] TARGET ARTIFACT: [INFO] groupId: JPP/vdsm-jsonrpc-java [INFO] artifactId: root [INFO] extension: pom [INFO] classifier: [INFO] version: SYSTEM [INFO] stereotype: pom [INFO] namespace: [INFO] file: usr/share/maven-poms/JPP.vdsm-jsonrpc-java-root.pom [INFO] =============================================== java.lang.ArrayIndexOutOfBoundsException: 4648 at org.objectweb.asm.ClassReader.readClass(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.objectweb.asm.ClassReader.accept(Unknown Source) at org.fedoraproject.maven.installer.impl.DefaultInstaller.usesNativeCode(DefaultInstaller.java:545) at org.fedoraproject.maven.installer.impl.DefaultInstaller.installArtifact(DefaultInstaller.java:574) at org.fedoraproject.maven.installer.impl.DefaultInstaller.install(DefaultInstaller.java:758) at org.fedoraproject.maven.tools.installer.InstallerCli.run(InstallerCli.java:174) at org.fedoraproject.maven.tools.installer.InstallerCli.main(InstallerCli.java:187) error: Bad exit status from /var/tmp/rpm-tmp.KMxx5N (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.KMxx5N (%install) Took 71 seconds =================================== No idea about why this happen, never seen it in other builds. I can only guess that something in the generated pom file is not resolvable by the installer using JDK 1.7. Maybe try with JDK 1.8 as in Fedora? On Tue, Oct 4, 2016 at 8:58 PM, Martin Perina <mperina@redhat.com> wrote:
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

On Wed, Oct 5, 2016 at 9:34 AM, Piotr Kliczewski <pkliczew@redhat.com> wrote:
That may be the clue. the EL7 build is using jdk 1.7 not 1.8.
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

I talked to xmvn maintainer and it seems that xmvn uses asm 3 to analyze the code after the build. This library do not support java8 syntax. I was asked to open a BZ for it [1] Now we are thinking how to workaround the issue before the fix will be available. Thanks, Piotr [1] https://bugzilla.redhat.com/1381883 On Wed, Oct 5, 2016 at 10:00 AM, Piotr Kliczewski <pkliczew@redhat.com> wrote:

On Wed, Oct 5, 2016 at 11:26 AM, Piotr Kliczewski <pkliczew@redhat.com> wrote:
I'll try to escalate the bug. The patch attached to the BZ looks simple enough, if it may help I can try to provide an updated version of xmvn within CentOS Virt SIG for 4.1 candidate repos. May this help?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

On Thu, Oct 6, 2016 at 12:07 PM, Piotr Kliczewski <pkliczew@redhat.com> wrote:
Ok, did it, you need to add https://cbs.centos.org/repos/virt7-ovirt-41-candidate/x86_64/os/ to your repos files in standard-ci automation directory
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

On Thu, Oct 6, 2016 at 2:40 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
I added it here [1] and run the build [2] and I saw the same issue. [1] https://gerrit.ovirt.org/#/c/64481/7/automation/build-artifacts.repos.el6 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64...

On Thu, Oct 6, 2016 at 3:27 PM, Piotr Kliczewski <pkliczew@redhat.com> wrote:
You added to el6 repo, you should have added it to el7 :-) build- artifacts.repos.el7
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

On Thu, Oct 6, 2016 at 4:04 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
I added el7 [1] and simlink [2] but still the same [3] and I can see that the repo was added: *14:16:23* Adding repo centos -> https://cbs.centos.org/repos/virt7-ovirt-41-candidate/x86_64/os/ [1] https://gerrit.ovirt.org/#/c/64481/8/automation/build-artifacts.repos.el7 [2] https://gerrit.ovirt.org/#/c/64481/8/automation/check-patch.repos.el7 [3] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64...

On Thu, Oct 6, 2016 at 4:26 PM, Piotr Kliczewski <pkliczew@redhat.com> wrote:
The package is correctly installed: *00:02:20.007* xmvn.noarch 0:1.3.0-5.1.el7 So the provided patch is not fixing your issue. -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

Hi Sandro, does this means that we cannot use xmvn build with JDK 1.8? If so, then we would need to use same as engine (create Makefile which executes normal maven), right? For otopi/ovirt-host-deploy you are still using 1.7? Thanks Martin On Thu, Oct 6, 2016 at 5:45 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:

On Thu, Oct 6, 2016 at 9:49 PM, Martin Perina <mperina@redhat.com> wrote:
This means that the pach supposed to fix the bug ( https://bugzilla.redhat.com/attachment.cgi?id=1207515&action=diff) is not working. I've seen that a new patch ( https://bugzilla.redhat.com/attachment.cgi?id=1207977&action=diff) has been attached to the xmvn bug ( https://bugzilla.redhat.com/show_bug.cgi?id=1381883) I'm going to rebuild xmvn using the new patch so we can test it.
For otopi/ovirt-host-deploy you are still using 1.7?
otopi and ovirt-host-deploy are using 1.5.
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

On Fri, Oct 7, 2016 at 8:23 AM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
xmvn-1.3.0-5.2.el7 is now available in CentOS Virt SIG candidate repo. The new patch is working: http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64...
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>
participants (3)
-
Martin Perina
-
Piotr Kliczewski
-
Sandro Bonazzola