+1, thanks. Please continue to let us know if we need to enforce other hooks more strictly as well :) On Mon, Jan 30, 2017 at 3:29 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > Yeah I've noticed the hook identified the situation, I'm asking you to > make it more stricter, hence the email :) > > On Mon, Jan 30, 2017 at 3:22 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > >> It already WARN on it: >> >> - Check TM::#1416309::WARN, wrong target milestone: ovirt-4.2.0 >> >> We can make it more strict and give VERIFY -1. >> Adding infra-support to open a ticket on it. >> >> We intentionally didn't enforce Verify as default since we wanted to >> give time to the hook >> to work and see we don't have false positives on it. >> >> >> On Mon, Jan 30, 2017 at 3:13 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: >> >>> Example: >>> https://gerrit.ovirt.org/#/c/71374/ >>> >>> I'd expect the Gerrit hooks to give -1 on verified when a 4.2 bug is >>> pushed into the 4.1 stable branch >>> >>> Thanks. >>> >>> _______________________________________________ >>> Infra mailing list >>> Infra(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/infra >>> >>> >> >> >> -- >> Eyal Edri >> Associate Manager >> RHV DevOps >> EMEA ENG Virtualization R&D >> Red Hat Israel >> >> phone: +972-9-7692018 <+972%209-769-2018> >> irc: eedri (on #tlv #rhev-dev #rhev-integ) >> > > -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

Re: Wrong target milestone bugs should be blocked with -verified on the stable branches --------------------------------------------------------------------------------------- Key: OVIRT-1089 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1089 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: eyal edri [Administrator] Assignee: Shlomo Ben David It already WARN on it: - Check TM::#1416309::WARN, wrong target milestone: ovirt-4.2.0 We can make it more strict and give VERIFY -1. Adding infra-support to open a ticket on it. We intentionally didn't enforce Verify as default since we wanted to give time to the hook to work and see we don't have false positives on it. On Mon, Jan 30, 2017 at 3:13 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > Example: > https://gerrit.ovirt.org/#/c/71374/ > > I'd expect the Gerrit hooks to give -1 on verified when a 4.2 bug is > pushed into the 4.1 stable branch > > Thanks. > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > > -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)