[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33139#comment-33139 ] Allon Mureinik edited comment on OVIRT-1500 at 7/3/17 11:52 AM: ---------------------------------------------------------------- {quote} So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no? {quote} Eyal - the behavior of just marking patchset #1 with CI=+1 is correct. I want this value *copied* to patchset #2, so it's visible from gerrit's dashboard. Otherwise, I need to see there's no CI score on the dashboard, go into this patch, read through the history to understand why it was never triggered on patchset #2 and mark CI=+1 myself (or manually trigger) in order to merge. Nothing here is technically "wrong", but it's a poor UX for gerrit users, and we should strive to improve it if possible. was (Author: mureinik):

So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no?

Eyal - the behavior of just marking patchset #1 with CI=+1 is correct. I want this value **copied** to patchset #2, so it's visible from gerrit's dashboard. Otherwise, I need to see there's no CI score on the dashboard, go into this patch, read through the history to understand why it was never triggered on patchset #2 and mark CI=+1 myself (or manually trigger) in order to merge. Nothing here is technically "wrong", but it's a poor UX for gerrit users, and we should strive to improve it if possible.

CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit -------------------------------------------------------------------

Key: OVIRT-1500 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 Project: oVirt - virtualization made easy Issue Type: Bug Components: Gerrit/git, oVirt CI Reporter: Allon Mureinik Assignee: infra

In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. Looking through gerrit's history, here's what I *think* is going on: 08:41 - patchset #1 is submitted 08:41 - CI (check-patch) starts for both EL7 and fc25 _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ 08:42 - patchset #2 is submitted _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. Expected behavior: If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.

-- This message was sent by Atlassian JIRA (v1000.1092.1#100053)