gerrit requiring signed-off-by?
--=-fR9FuAWAz+2VWixO9Nm3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey, is it new that gerrit requires commits to have the SIgned-Off-By string in the commit msg? Thanks fabian --=-fR9FuAWAz+2VWixO9Nm3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAABAgAGBQJS5+TuAAoJEC9+uOgSHVGUHvgP/2rcwuahjLkJIRHByftk5zYE n1LmspGCmYmW2HX6jlgyfLc/NdxK9W/BYlm2QPUo59/YAfc3V4ikzohLzz/Ma4Ut SpjqpFnPOpTxMF/rPdNoyCI7DrKAQmeBFihJZURJ+OiLES9xRjaP+e4E9L9ww1ls LJMCVX45opBDjuVFToTT8OlEhfTRCFlvBNwTe/q31oEkXbGfyRkomQEaN9IjBIbC zsqdR3BAj55jcYvC9oaOSTWkzI5emGmhDSmh9199nx/nq+A5eJTPhbWJsgn2X5/+ YNW6gYylE3v5iXw8Lqr1T30ETzK5JBF/MWsC3C1ty/Oqh8+XC6FnUGRpnFB+PTPj Kk+4VH/qG83RixsYibOvo193sLjrujRTXoPF2LIhTOObmuEsg1m3beO9JcrCYxUR 54LE7C/UjoAKDYCJyCBzXh8hReZpkA57WHAhSuEdRKuWGPFf4QLcywO9foLiGRr0 5kqTshMofEbHUSGq5BfjafbW585fe3i9AhwDqzKRaaikjrbEpRxxaXqIxqEmpTUT m6NGp8fWI2ObkaUp4hO91UPvvo0uylKTcPuaK7+Mn8QfTZN0E/OCVRsMcT00H7PT PraeUBiZ89qXKdz6emyQtwKR+wpc+V7ESU7ZtHOqgV0Zp4Arn4xChP9deCs37fhU /Ipg+cVp0ECFo/ykrX5J =4TT0 -----END PGP SIGNATURE----- --=-fR9FuAWAz+2VWixO9Nm3--
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8giQRDbXw62dhmTmEOg1sfPiMfbpW88pE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable El mar 28 ene 2014 18:12:14 CET, Fabian Deutsch escribi=C3=B3:
Hey,
is it new that gerrit requires commits to have the SIgned-Off-By string=
Which project are you referring to? As far as I remember most of the projects required it and some did not.=20 I don't remember changing it though, so the projects that did not=20 require it should haven't started requiring them. Tell me the project=20 you are referring too and I'll take a look. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --8giQRDbXw62dhmTmEOg1sfPiMfbpW88pE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJS6A2jAAoJEEBxx+HSYmnDmMkH/R1Oppnmgeh8pL7wgqPDaw/p 4DIlCSClscSN+Qz/tW7zNPkkfONKRKOgZtZ/cxfb+FwtKhDIxBzl8VobCqQenTDU u7GXJvfrkGga5YaQLIi5fWe7r3RI4/YdKUI38hbtJlne3ily4x60x0qqiiBPs1Ia aNpmRx83waMNBrflQ/2e4bBsAyHEP06IhkoCcUcB2dPl8eWx1w+BLfYn2U71xQk6 eIH0S24VI88WH4fDvSy/Q17kQnUBHzoRrxqSMlTYz9GT9D08NcOSuRDm1dekE3u5 +YfT1xpdLeW00CW8uc7k7c1Z5WlrQVymUgt5nw+Y+DUBBdo4e5qPi+ZXszagR7E= =q2xj -----END PGP SIGNATURE----- --8giQRDbXw62dhmTmEOg1sfPiMfbpW88pE--
--=-UJLgURkJ4g/FxrgmKpUx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Mittwoch, den 29.01.2014, 22:00 +0200 schrieb Itamar Heim:
Yes. It was my missunderstanding. The gerrit rule checks is not just chekcing the presence of the line but also that this line matches either the submitter or the author. The patch I was looking at, had a Signed-Off-By line which differed from the author. - fabian
--=-UJLgURkJ4g/FxrgmKpUx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAABAgAGBQJS8fXNAAoJEC9+uOgSHVGUgcAQAJZ1XcZjME7ZhgoupgEBa5YA xxQIMVbBvrjAfOTsA2dyHybe0dNZdwG42/VWeRHN8RBDe/Oz0ewufMzfP/QwCTxP bvcTe91xFBxT9D9jOrsQNgAf53xiwiGPKFof9l1tF+qxNKlnunp+c1QPoyjRF1Hu UDRHmk0Vgr8TVHKly44/EU3YOXC3no6kuS1qiYQtBEMUNK+/1BpatcDXaobJE5hd 8+QJAO/Qg1UD0jWXrYBKhEax0n2Mt7iKDmS0d4zgWMdLW7VzetmhejIgCiuzH8Xw chZ96HGuVDGFixJEm0uZLK5jlNB9ZzqkjLjM1XVt+EF2tehcBpbU1ox78BQTr7Lg 1ojJ5JGTf+P+o9EgN5u+YVr5+bD0JNwSvQ+s+QSSwu9CrUH2ox6KmRs9/9DOC0oA Pzd2ClIvbemdmdrJ1TIZdsCscbs9J4XnxtCnHg/nAzDJ8I92lu/eUkTmxh1KyOqg OY1oBoSu+Iev9gxtdbn+UX2PT3GNYeF/ntiSIUo0qsutp9zYnfQwcllIynxsK+AB q/gGqQqyIBdLQJEj5NMmoP10EaVg9yUExb0io53dwR8STK7r3vbbMmf08ZIGpLat JulzIGPOyzSOLzpjLSba0OaN5Abgt91AnTTArk/UT6+fI4NGdtqXsXA9a6bNI7b1 kdfhyWyOGLzyfKTIQ0cL =2SVD -----END PGP SIGNATURE----- --=-UJLgURkJ4g/FxrgmKpUx--
participants (3)
-
David Caro -
Fabian Deutsch -
Itamar Heim