On 10. 7. 2021, at 0:14, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: On Sat, Jul 10, 2021 at 12:59 AM Nir Soffer <nsoffer(a)redhat.com&gt; wrote: > > OST failed, and posted unprocessed comment: > > OST Verified -1 > Patch Set 1: Verified-1 > https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 : > OST https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/$OST_NUMBER > failed with: $OST_MESSAGE > > https://gerrit.ovirt.org/c/vdsm/+/115642#message-b2993761_adbc1b6a > > Looking at: > https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 > > It looks like environment issue: > > ERROR: Build step failed with exception > > java.lang.NullPointerException: no workspace from node > hudson.slaves.DumbSlave[hpe-bl280g6-12...] which is computer > hudson.slaves.SlaveComputer@2e2cb321 and has channel null > > So we have 2 issues: > 1. If build fails, error is not handled properly producing bad comment > 2. the actual build failure I started another build manually (8543) and it started normally, so this was probably a temporary issue.

> > The first issue should be handled by posting a better comment: > > OST build error: > https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 > > And OST should not mark the patch as verified -1, since it did not run any test.

> > Marking a patch as -1 means some tests have failed, and the author > needs to check > why. A build error means OST or CI maintainers need to check why the > error happened. _______________________________________________ Devel mailing list -- devel(a)ovirt.org To unsubscribe send an email to devel-leave(a)ovirt.org Privacy Statement: https://www.ovirt.org/privacy-policy.html oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/devel@ovirt.org/message/H4Q2MT7R7DX...

OST failure, bad comment ------------------------ Key: OVIRT-3110 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3110 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Nir Soffer Assignee: infra OST failed, and posted unprocessed comment: OST Verified -1 Patch Set 1: Verified-1 https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 : OST https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/$OST_NUMBER failed with: $OST_MESSAGE https://gerrit.ovirt.org/c/vdsm/+/115642#message-b2993761_adbc1b6a Looking at: https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 It looks like environment issue: ERROR: Build step failed with exception java.lang.NullPointerException: no workspace from node hudson.slaves.DumbSlave[hpe-bl280g6-12...] which is computer hudson.slaves.SlaveComputer@2e2cb321 and has channel null So we have 2 issues: 1. If build fails, error is not handled properly producing bad comment 2. the actual build failure The first issue should be handled by posting a better comment: OST build error: https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 And OST should not mark the patch as verified -1, since it did not run any test. Marking a patch as -1 means some tests have failed, and the author needs to check why. A build error means OST or CI maintainers need to check why the error happened.