From: "Kiril Nesenko" <kiril(a)redhat.com&gt; To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt; Sent: Tuesday, May 7, 2013 10:33:33 PM Subject: Engine Upgrade job Hello, I am working on engine upgrade job. I have a slave with 'ip-10-82-253-208' hostname. This job fails on engine-setup [1] because of this hostname. Sandro, Alex can you take a look please ?

[1] http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/... - Kiril _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

From: "Alex Lourie" <alourie(a)redhat.com&gt; To: "Ohad Basan" <obasan(a)redhat.com&gt; Cc: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt;, "Kiril Nesenko" <kiril(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; Sent: Wednesday, May 8, 2013 12:37:06 AM Subject: Re: Engine Upgrade job On Tue, May 7, 2013 at 10:53 PM, Ohad Basan <obasan(a)redhat.com&gt; wrote: > > > ----- Original Message ----- >> From: "Kiril Nesenko" <kiril(a)redhat.com&gt; >> To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" >> <sbonazzo(a)redhat.com&gt; >> Cc: "infra" <infra(a)ovirt.org&gt; >> Sent: Tuesday, May 7, 2013 10:33:33 PM >> Subject: Engine Upgrade job >> >> Hello, >> I am working on engine upgrade job. I have a slave with >> 'ip-10-82-253-208' >> hostname. >> This job fails on engine-setup [1] because of this hostname. >> Sandro, Alex can >> you take a look please ? >> > this is due to the following code: > > if not validateDomain(param,options): > return False > > in engine-validators.py > we can patch this out just for the upgrade job or change the regex > that is being used. > The failing job is actually the correct behavior. The provided FQDN parameter failed validation (as Ohad said). You can choose to ignore the validator by commenting out the code, but you'll have to do it in every job and for each test for each patch. The other way would be providing a real fqdn in answer file, which is much better solution.

> > >> >> [1] >> >> http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/... >> >> - Kiril >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra >> >> _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

From: "Eyal Edri" <eedri(a)redhat.com&gt; To: "Kiril Nesenko" <kiril(a)redhat.com&gt; Cc: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; Sent: Wednesday, May 8, 2013 2:37:16 PM Subject: Re: Engine Upgrade job go for it.

----- Original Message ----- > From: "Kiril Nesenko" <kiril(a)redhat.com&gt; > To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Eyal Edri" <eedri(a)redhat.com&gt; > Cc: "Ohad Basan" <obasan(a)redhat.com&gt;, "Sandro Bonazzola" > <sbonazzo(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; > Sent: Wednesday, May 8, 2013 2:35:16 PM > Subject: Re: Engine Upgrade job > > > > ----- Original Message ----- > > From: "Alex Lourie" <alourie(a)redhat.com&gt; > > To: "Ohad Basan" <obasan(a)redhat.com&gt; > > Cc: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt;, "Kiril Nesenko" > > <kiril(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; > > Sent: Wednesday, May 8, 2013 12:37:06 AM > > Subject: Re: Engine Upgrade job > > > > > > > > On Tue, May 7, 2013 at 10:53 PM, Ohad Basan <obasan(a)redhat.com&gt; wrote: > > > > > > > > > ----- Original Message ----- > > >> From: "Kiril Nesenko" <kiril(a)redhat.com&gt; > > >> To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" > > >> <sbonazzo(a)redhat.com&gt; > > >> Cc: "infra" <infra(a)ovirt.org&gt; > > >> Sent: Tuesday, May 7, 2013 10:33:33 PM > > >> Subject: Engine Upgrade job > > >> > > >> Hello, > > >> I am working on engine upgrade job. I have a slave with > > >> 'ip-10-82-253-208' > > >> hostname. > > >> This job fails on engine-setup [1] because of this hostname. > > >> Sandro, Alex can > > >> you take a look please ? > > >> > > > this is due to the following code: > > > > > > if not validateDomain(param,options): > > > return False > > > > > > in engine-validators.py > > > we can patch this out just for the upgrade job or change the regex > > > that is being used. > > > > > > > The failing job is actually the correct behavior. The provided FQDN > > parameter failed validation (as Ohad said). > > > > You can choose to ignore the validator by commenting out the code, but > > you'll have to do it in every job and for each test for each patch. > > > > The other way would be providing a real fqdn in answer file, which is > > much better solution. > > Thanks Alex. Eyal, can we change the hostname of this slave to a real one ? > > > > > > > > > > >> > > >> [1] > > >> > > >> http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/... > > >> > > >> - Kiril > > >> _______________________________________________ > > >> Infra mailing list > > >> Infra(a)ovirt.org > > >> http://lists.ovirt.org/mailman/listinfo/infra > > >> > > >> > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

From: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt; To: "Kiril Nesenko" <kiril(a)redhat.com&gt; Cc: "Alex Lourie" <alourie(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt;, "Eyal Edri" <eedri(a)redhat.com&gt; Sent: Thursday, May 9, 2013 11:05:27 AM Subject: Re: Engine Upgrade job You're using just ip-10-82-253-208 as fqdn. If you attach the domain it should validate: try using something like ip-10-82-253-208.your.domain.name if the DNS doesn't resolve the full domain name, add a line in /etc/hosts assigning the full domain name to the same IP address assigned to ip-10-82-253-208 Il 09/05/2013 10:00, Kiril Nesenko ha scritto: > ----- Original Message ----- >> From: "Eyal Edri" <eedri(a)redhat.com&gt; >> To: "Kiril Nesenko" <kiril(a)redhat.com&gt; >> Cc: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" >> <sbonazzo(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; >> Sent: Wednesday, May 8, 2013 2:37:16 PM >> Subject: Re: Engine Upgrade job >> >> go for it. > I changed the hostname. But there is no A record for slaves ip. > Alix, Sandro because we are talking about public servers, I think that > there will be some issues with hostnames. > Is there any workaround for this ? To pass this validation ? > > - Kiril >> ----- Original Message ----- >>> From: "Kiril Nesenko" <kiril(a)redhat.com&gt; >>> To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Eyal Edri" <eedri(a)redhat.com&gt; >>> Cc: "Ohad Basan" <obasan(a)redhat.com&gt;, "Sandro Bonazzola" >>> <sbonazzo(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; >>> Sent: Wednesday, May 8, 2013 2:35:16 PM >>> Subject: Re: Engine Upgrade job >>> >>> >>> >>> ----- Original Message ----- >>>> From: "Alex Lourie" <alourie(a)redhat.com&gt; >>>> To: "Ohad Basan" <obasan(a)redhat.com&gt; >>>> Cc: "Sandro Bonazzola" <sbonazzo(a)redhat.com&gt;, "Kiril Nesenko" >>>> <kiril(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; >>>> Sent: Wednesday, May 8, 2013 12:37:06 AM >>>> Subject: Re: Engine Upgrade job >>>> >>>> >>>> >>>> On Tue, May 7, 2013 at 10:53 PM, Ohad Basan <obasan(a)redhat.com&gt; wrote: >>>>> >>>>> ----- Original Message ----- >>>>>> From: "Kiril Nesenko" <kiril(a)redhat.com&gt; >>>>>> To: "Alex Lourie" <alourie(a)redhat.com&gt;, "Sandro Bonazzola" >>>>>> <sbonazzo(a)redhat.com&gt; >>>>>> Cc: "infra" <infra(a)ovirt.org&gt; >>>>>> Sent: Tuesday, May 7, 2013 10:33:33 PM >>>>>> Subject: Engine Upgrade job >>>>>> >>>>>> Hello, >>>>>> I am working on engine upgrade job. I have a slave with >>>>>> 'ip-10-82-253-208' >>>>>> hostname. >>>>>> This job fails on engine-setup [1] because of this hostname. >>>>>> Sandro, Alex can >>>>>> you take a look please ? >>>>>> >>>>> this is due to the following code: >>>>> >>>>> if not validateDomain(param,options): >>>>> return False >>>>> >>>>> in engine-validators.py >>>>> we can patch this out just for the upgrade job or change the regex >>>>> that is being used. >>>>> >>>> The failing job is actually the correct behavior. The provided FQDN >>>> parameter failed validation (as Ohad said). >>>> >>>> You can choose to ignore the validator by commenting out the code, but >>>> you'll have to do it in every job and for each test for each patch. >>>> >>>> The other way would be providing a real fqdn in answer file, which is >>>> much better solution. >>> Thanks Alex. Eyal, can we change the hostname of this slave to a real one >>> ? >>>>> >>>>>> >>>>>> [1] >>>>>> >>>>>> http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/... >>>>>> >>>>>> - Kiril >>>>>> _______________________________________________ >>>>>> Infra mailing list >>>>>> Infra(a)ovirt.org >>>>>> http://lists.ovirt.org/mailman/listinfo/infra >>>>>> >>>>>> >>>> _______________________________________________ >>>> Infra mailing list >>>> Infra(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/infra >>>> >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra >> -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com