----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Eyal Edri" <eedri@redhat.com> Cc: infra@ovirt.org Sent: Thursday, 16 April, 2015 10:23:08 PM Subject: Re: New workflow flag on gerrit jenkins project
On 04/15, Eyal Edri wrote:
+1. Excellent. Will it be possible to tell gerrit trigger plugin to run jobs only on patches with this flag?
If not, might worth sending a patch to support it. It might reduce dramatically the amount of jobs running on patches.
Yes, the gerrit plugin does allow filtering by any custom flag (just checked)
can you open a trac ticket on it so we'll implement it?
Sent from Nine
From: David Caro Sent: Apr 15, 2015 7:31 PM To: infra@ovirt.org Subject: New workflow flag on gerrit jenkins project
Hi!
As a test to improve the review process I've enabled a new flag on the jenkins repo, the workflow flag.
This flag has three values: 0 Work in progress (default) +1 Ready for review +2 Ready for merge
The idea is to work on a patch without bothering anyone and when ready, explicitly ask for review in gerrit, that way the reviewer can easily differenciate between ready and not ready patches. Once the reviews have been done and all, the maintainer can set the +2 and merge the patch (the idea is in the near future use that flag to trigger zuul, so replacing the submit button).
The new flag shows nicely in the changes screen, making in really easy to see which patches require reviews.
Let's play on that project only for now and see if it works out.
Thanks!!
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra