Re: Static analysis for oVirt

From: "Piotr Kliczewski" <piotr.kliczewski(a)gmail.com&gt; To: "Allon Mureinik" <amureini(a)redhat.com&gt; Cc: infra(a)ovirt.org Sent: Sunday, September 29, 2013 9:04:09 PM Subject: Re: Static analysis for oVirt Allon, Sonar is similar to findbugs but it gives you code duplication, complexity, coverage and help you understand how metrics change over the time. There is a bit "noise" with default configuration but it can be nicely tuned: http://www.sonarqube.org/screencasts/configuring-coding-rules/ you can run it together with your Jenkins build by using: https://wiki.jenkins-ci.org/display/JENKINS/Sonar+plugin I used it in the past with Java code and I can say it gives good understanding of the code quality. I can help to set it up for one or more projects if there is a will to experiment. Thanks, Piotr On Sun, Sep 29, 2013 at 6:23 PM, Allon Mureinik < amureini(a)redhat.com > wrote: Hi Piotr, Currently, we employ several static analysis tools in the various oVirt projects. In oVirt-Engine: 1. We use checkstyle at build time with several standard checks, and a couple implemented by project members 2. FindBugs is run by a Jenkins job: http://jenkins.ovirt.org/view/All/job/ovirt_engine_find_bugs/ 3. Animal Sniffer is used to ensure we don't break JDK6 compatibility on GWT-compiled modules (should probably be removed since the last GWT upgrade, BTW), also as a Jenkins job: http://jenkins.ovirt.org/job/ovirt_engine_animal_sniffer_check/ 4. pylint is used to check the python parts: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_pylint_gerrit/ In VDSM, we use pep8 as part of the build. Personally, I've heard about Sonar Qube, but never used it. Can you share some experience? How much "noise" does it produce? -Allon From: "Piotr Kliczewski" < piotr.kliczewski(a)gmail.com > To: infra(a)ovirt.org Sent: Sunday, September 29, 2013 7:00:58 PM Subject: Static analysis for oVirt All, Is there static analysis tool used for oVirt code base? There is interesting tool called Sonar: http://www.sonarqube.org/ . It integrates with Jenkins and provides you neat dashboard that will let you understand code quality. This tool supports many languages including Java and Python. Thanks, Piotr Kliczewski _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra