On Mon, Oct 15, 2012 at 06:59:25PM +0200, Itamar Heim wrote:
On 10/15/2012 06:39 PM, Karsten 'quaid' Wade wrote:
* Gerrit admins need to enable viewing of drafts * eedri to follow up with itamar about enabling this option on gerrit
anyone knows this is possible? the definition of the drafts features is:
"Drafts
A change can be submitted as a draft if, for example, it's not ready for merging, or even general code review, but you would like to share it selectively to get early comments. If you upload a change as a draft, by default, no one else can see it. You must explicitly add each person you would like to share it with as a reviewer. Reviewers you add can leave comments, but cannot vote at this stage. You can continue to upload new patchsets to the change as it evolves, and once it is ready for general review, you can click the "Publish" button. It will then become a normal change in Gerrit that everyone can see, including the earlier reviews from the draft stage. This is a one way transition; once a draft is published, it can't be made a draft again.
A draft change is uploaded by adding the "-D" option. Simply make changes, commit them, and submit them as a draft:
git commit -a git review -D"
Personally I'm fine with this solution as long it's communicated clearly. I suppose it would be nice to mark your draft as public for proof-of-concept patches, but the main objective is then to not merge them until they are ready. Since I think that's covered by our maintainers it's an invoncenience and ugly, but unlikely to degrade the general code quality.